Do not show embed intent when editing is disabled

fixes #129

src/js/editor/editor.js

@@ -429,7 +429,6 @@ class Editor {
    * programmatic API is still permitted.
    *
    * @method disableEditing
-   * @return undefined
    * @public
    */
   disableEditing() {

src/js/views/embed-intent.js

@@ -59,6 +59,7 @@ class EmbedIntent extends View {
     const embedIntentHandler = () => {
       const { editor } = this;
       if (this._isDestroyed || editor._isDestroyed) { return; }
+      if (!editor.isEditable) { return; }
 
       let showElement;
 

tests/acceptance/embed-intent-test.js

@@ -154,3 +154,22 @@ test('clicking in empty mobiledoc shows embed intent', (assert) => {
     });
   });
 });
+
+test('when editing is disabled, embedIntent does not show', (assert) => {
+  const done = assert.async();
+  const mobiledoc = Helpers.mobiledoc.build(({post}) => post());
+  editor = new Editor({mobiledoc});
+  editor.disableEditing();
+  editor.render(editorElement);
+
+  assert.hasElement('#editor', 'precond - editor');
+  assert.hasNoElement('#editor p', 'precond - editor has no p');
+
+  Helpers.dom.moveCursorTo($('#editor')[0]);
+  Helpers.dom.triggerEvent(document, 'click');
+
+  setTimeout(() => {
+    assertHasNoEmbedIntent(assert, 'embed intent not shown');
+    done();
+  });
+});