Expose card env to ember component cards #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My understanding of mobiledoc-kit's Card API is that `env` is part of the public API that a card receives from mobiledoc. If so, then it should be accessible to ember component cards. An example of a property accessible to cards that wasn't accessible to ember component cards is `env.isInEditor`.
|
👍 |
|
thanks! |
bantic
added a commit
that referenced
this pull request
Mar 22, 2016
Expose card env to ember component cards
bantic
added a commit
that referenced
this pull request
Mar 22, 2016
Tests for env, editCard, saveCard, cancelCard, removeCard properties and that `env.isInEditor` is true Refs #64
|
released in v0.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My understanding of mobiledoc-kit's Card API is that
envis part of the public API that a card receives from mobiledoc. If so, then it should be accessible to ember component cards.An example of a property accessible to cards that wasn't accessible to ember component cards is
env.isInEditor.