Skip to content

Commit

Permalink
made the fallback more friendly for simple DOM
Browse files Browse the repository at this point in the history
  • Loading branch information
habdelra committed Jun 3, 2016
1 parent 0b3545e commit 6df69ad
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
9 changes: 5 additions & 4 deletions addon/utils/create-component-atom.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,22 @@ const RENDER_TYPE = 'dom';

import { ADD_ATOM_HOOK, REMOVE_ATOM_HOOK } from '../components/mobiledoc-editor/component';

function renderFallback() {
function renderFallback(doc) {
let element = document.createElement('span');
element.innerHTML = '[placeholder for Ember atom]';
let text = doc.createTextNode('[placeholder for Ember atom]');
element.appendChild(text);
return element;
}

export default function createComponentAtom(name) {
export default function createComponentAtom(name, doc = window.document) {

return {
name,
type: RENDER_TYPE,
render(atomArg) {
let {env, options} = atomArg;
if (!options[ADD_ATOM_HOOK]) {
return renderFallback();
return renderFallback(doc);
}

let { atom, element } = options[ADD_ATOM_HOOK](atomArg);
Expand Down
3 changes: 2 additions & 1 deletion addon/utils/create-component-card.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ import { ADD_CARD_HOOK, REMOVE_CARD_HOOK } from '../components/mobiledoc-editor/

function renderFallback(doc) {
let element = doc.createElement('div');
element.innerHTML = '[placeholder for Ember component card]';
let text = doc.createTextNode('[placeholder for Ember component card]');
element.appendChild(text);
return element;
}

Expand Down

0 comments on commit 6df69ad

Please sign in to comment.