Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should disallow drawing on left or right of the image #379

Closed
stephanepechard opened this issue Jul 19, 2021 · 4 comments · Fixed by #380
Closed

Should disallow drawing on left or right of the image #379

stephanepechard opened this issue Jul 19, 2021 · 4 comments · Fixed by #380
Labels

Comments

@stephanepechard
Copy link
Contributor

Describe the bug
Currently, it is possible to draw on the outside (right and left only) of the selected image, due to the way the layout is set.

To Reproduce
Steps to reproduce the behavior:

  1. Select an image that lets right and left sides empty (black on the demo app ;
  2. Brush on these parts ;
  3. You can see shapes on the outside of the image.

Expected behavior
It is not possible to draw outside of the given image, drawing should be cropped.

Screenshot
Screenshot_1626709982

Smartphone Info:

  • Version 1.5.0 on any device
@burhanrashid52
Copy link
Owner

burhanrashid52 commented Jul 20, 2021

Can we make it configurable from PhotoEditor.Builder says setShapeClip(true) by default it will be false, so that it does not break the existing behavior.

@ToanNguyen97
Copy link

Hi!, this is a wonderful feature, I really need it but seems it's not have in lastest release version, right?
Please tell me how I can add it, tks

@burhanrashid52
Copy link
Owner

Currently it's not merged and hence not release. Will release it soon.

@ToanNguyen97
Copy link

tks so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants