Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded - Refactor authorization - Add protected fetch for private gems #94

Merged

Conversation

rjocoleman
Copy link
Contributor

@rjocoleman rjocoleman commented May 21, 2016

This builds on #92, #93 and resolves #24

@smellsblue I think this covers off all your feedback - thanks!

This PR contains:

  • Iteration on @smellsblue's work on the Authorization refactor
  • protected_fetch (default false) in Gemstash::Configuration
  • Configuration of protected_fetch via $ gemstash setup
  • A new fetch permission for Authorization
  • Authentication via HTTP Basic Auth (token as username) to support gem, bundler and uri based auth in Gemfiles
  • Docs to suit.

@rjocoleman
Copy link
Contributor Author

@smellsblue if this is acceptable I'll do the serve_gem and serve_marshal methods in a similar way and stick them in this PR too.

@rjocoleman rjocoleman force-pushed the refactor-authorization branch from 6f92e9d to dbdef68 Compare May 21, 2016 11:07
@rjocoleman rjocoleman changed the title Expanded - Refactor authorization WIP - Expanded - Refactor authorization May 21, 2016
@rjocoleman rjocoleman force-pushed the refactor-authorization branch from 9b5a58c to c2473e4 Compare May 21, 2016 12:03
@rjocoleman rjocoleman changed the title WIP - Expanded - Refactor authorization Expanded - Refactor authorization May 22, 2016
@rjocoleman
Copy link
Contributor Author

@smellsblue Pending any further feedback, this should be good to go

@rjocoleman rjocoleman changed the title Expanded - Refactor authorization Expanded - Refactor authorization - Add protected fetch for private gems May 22, 2016
@smellsblue smellsblue merged commit 97eda57 into rubygems:refactor-authorization May 25, 2016
@rjocoleman rjocoleman deleted the refactor-authorization branch May 25, 2016 22:28
@smellsblue smellsblue mentioned this pull request Oct 17, 2016
@dazuma dazuma mentioned this pull request Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants