Added support for mysql2 adapter #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like rubocop is not happy with the changes, it just refuses to take conditionals at all. I would suggest to drop the rubocop yml changes to get the CI green, then we can just merge it in. |
This pull request also required an update to .rubocop-bundler.yml, but I left the rubocop updates for another PR to keep this one smaller.
pcarranza
added a commit
that referenced
this pull request
Jan 25, 2016
…pport Added support for mysql2 adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request also required an update to .rubocop-bundler.yml, but I left the satisfy-rubocop updates
for another PR to keep this one smaller.