Pull strategies and storage from bundler-api #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Cop supports --auto-correct. | ||
| # Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues. | ||
| Style/HashSyntax: | ||
| Enabled: false |
There was a problem hiding this comment.
Why not autocorrect these to make the project use a consistent hash syntax?
|
@sferik Hey, we didn't decide yet what rubocop configuration we are enabling by default, we are just adjusting that yet. I like the idea of enabling things with auto correct by default, is way less pain than being around fixing it by hand indeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract what we had there into gemstash
And some fiddling to make the rubocop pass, we need to talk to that guy 😞