Various fixes 3 #49
Merged
Various fixes 3 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otate) I chose 2 logs instead of 1 so if someone pokes around, it's clear the log is rotating I chose 10mb a bit arbitrarily
This gives us future flexibility to change the storage engine and know if a given resource is out of date Protect from loading a resource of a newer storage version
…ash version When loading the storage engine, check the storage version isn't too new
Move marshalled private gem specs to be saved with the gem
Move Gemstash::UpstreamGemName to Gemstash::Upstream::GemName
…ch has specialized checks
Use defaults in Gemstash::CLI::Setup path, mainly so tests can alter this safely Specs that the CLI version checking works ok Stub defaults to use test path, otherwise setup starts checking against your ~/.gemstash directory
|
Merging this now so we can release |
|
Ok, finally had a moment to go through it all (quite a "few fixes" you had XD) Anyway, it looks good, there are a few details that I would like to see ironed, but nothing blocker at all, just style and some things on clarity of code and error messages. Good job man! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some final changes before RC1.