Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jruby builds #193

Merged
1 commit merged into from
Oct 29, 2018
Merged

Fix jruby builds #193

1 commit merged into from
Oct 29, 2018

Conversation

bronzdoc
Copy link
Member

@bronzdoc bronzdoc commented Oct 29, 2018

Install jruby manually in a generic language image, since we can't modify the /home/travis/.rvm/gemsets/jruby/global.gems in what travis gives us.

travis home/travis/.rvm/gemsets/jruby/global.gems has in it jruby-openssl wich makes rvm install a new version of jruby-openssl whenever we install jruby, making the test suite run with that jruby-openssl version instead of the one that comes with jruby itself an break.

@bronzdoc bronzdoc mentioned this pull request Oct 29, 2018
@bronzdoc
Copy link
Member Author

@bundlerbot r+

ghost pushed a commit that referenced this pull request Oct 29, 2018
193: Fix jruby builds r=bronzdoc a=bronzdoc

Install jruby manually in a generic language image, since we can't modify the `/home/travis/.rvm/gemsets/jruby/global.gems` in what travis gives us.

travis `home/travis/.rvm/gemsets/jruby/global.gems`  has in it `jruby-openssl` wich makes rvm install a new version of `jruby-openssl` whenever we install jruby, making the test suite run with that `jruby-openssl` version instead of the one that comes with jruby itself an break.


Co-authored-by: Luis Sagastume <lsagastume1990@gmail.com>
@ghost
Copy link

ghost commented Oct 29, 2018

Build succeeded

@ghost ghost merged commit 00fe418 into master Oct 29, 2018
@olleolleolle olleolleolle deleted the fix_jruby_builds branch October 29, 2018 18:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant