Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rake: Turn rake task files into .rake files, auto-loaded #153

Merged
merged 1 commit into from
Aug 17, 2017

Conversation

olleolleolle
Copy link
Member

@olleolleolle olleolleolle commented Aug 1, 2017

This PR uses a feature in Rake, which is "any .rake file in rakelib/ will be auto-required by the Rakefile".

  • call the individual files .rake
  • put them in rakelib/
  • rename paths to supporting files (which now reside, a little incongruously in rake/)

Question

  • What are good places to place the citrus grammar and the Pandoc filter Ruby programs?

@bundlerbot
Copy link
Contributor

☔ The latest upstream changes (presumably #152) made this pull request unmergeable. Please resolve the merge conflicts.

  - call the files .rake
  - put them in rakelib/
  - smallest rename of the resource files
@olleolleolle olleolleolle force-pushed the fix/use-rakelib-folder branch from 0cd76cf to 7aaa440 Compare August 8, 2017 19:29
@jules2689
Copy link

@bundlerbot r+

@bundlerbot
Copy link
Contributor

📌 Commit 7aaa440 has been approved by jules2689

@bundlerbot
Copy link
Contributor

⌛ Testing commit 7aaa440 with merge 0706d17...

bundlerbot added a commit that referenced this pull request Aug 9, 2017
Rake: Turn rake task files into .rake files, auto-loaded

This PR uses a feature in Rake, which is "any .rake file in `rakelib/` will be auto-required by the Rakefile".

  - call the individual files `.rake`
  - put them in `rakelib/`
  - rename paths to supporting files (which now reside, a little incongruously in `rake/`)

## Question

- [ ] What are good places to place the citrus grammar and the Pandoc filter Ruby programs?
@bundlerbot
Copy link
Contributor

💥 Test timed out

@indirect
Copy link
Member

indirect commented Aug 9, 2017

@bundlerbot retry

@bundlerbot
Copy link
Contributor

⌛ Testing commit 7aaa440 with merge 6dd4276...

bundlerbot added a commit that referenced this pull request Aug 9, 2017
Rake: Turn rake task files into .rake files, auto-loaded

This PR uses a feature in Rake, which is "any .rake file in `rakelib/` will be auto-required by the Rakefile".

  - call the individual files `.rake`
  - put them in `rakelib/`
  - rename paths to supporting files (which now reside, a little incongruously in `rake/`)

## Question

- [ ] What are good places to place the citrus grammar and the Pandoc filter Ruby programs?
@bundlerbot
Copy link
Contributor

💥 Test timed out

@olleolleolle
Copy link
Member Author

@bundlerbot retry

@bundlerbot
Copy link
Contributor

⌛ Testing commit 7aaa440 with merge 00a6135...

bundlerbot added a commit that referenced this pull request Aug 17, 2017
Rake: Turn rake task files into .rake files, auto-loaded

This PR uses a feature in Rake, which is "any .rake file in `rakelib/` will be auto-required by the Rakefile".

  - call the individual files `.rake`
  - put them in `rakelib/`
  - rename paths to supporting files (which now reside, a little incongruously in `rake/`)

## Question

- [ ] What are good places to place the citrus grammar and the Pandoc filter Ruby programs?
@bundlerbot
Copy link
Contributor

💔 Test failed - status-travis

@olleolleolle
Copy link
Member Author

@bundlerbot retry

@bundlerbot
Copy link
Contributor

⌛ Testing commit 7aaa440 with merge 7d94d33...

bundlerbot added a commit that referenced this pull request Aug 17, 2017
Rake: Turn rake task files into .rake files, auto-loaded

This PR uses a feature in Rake, which is "any .rake file in `rakelib/` will be auto-required by the Rakefile".

  - call the individual files `.rake`
  - put them in `rakelib/`
  - rename paths to supporting files (which now reside, a little incongruously in `rake/`)

## Question

- [ ] What are good places to place the citrus grammar and the Pandoc filter Ruby programs?
@bundlerbot
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: jules2689
Pushing 7d94d33 to master...

@bundlerbot bundlerbot merged commit 7aaa440 into rubygems:master Aug 17, 2017
@olleolleolle olleolleolle deleted the fix/use-rakelib-folder branch August 17, 2017 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants