Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis: JRuby 9.1.7.0, gem update --system, format the buildfile #138

Merged
merged 5 commits into from
Jan 31, 2017
Merged

Travis: JRuby 9.1.7.0, gem update --system, format the buildfile #138

merged 5 commits into from
Jan 31, 2017

Conversation

olleolleolle
Copy link
Member

@olleolleolle olleolleolle commented Jan 28, 2017 •
edited
Loading

This PR fixes #137.

  • add whitespace to the file, to make it more readable
  • update JRuby to latest stable
  • add a before_install step to gem update --system
  • configure Rubocop to ignore gemfiles/**/* as well

@olleolleolle
Copy link
Member Author

@smellsblue That did it.

@olleolleolle
Copy link
Member Author

@smellsblue +r?

@olleolleolle olleolleolle changed the title Travis: gem update --sytem, format buildfile Travis: JRuby 9.1.7.0, gem update --system, format the buildfile Jan 29, 2017
@smellsblue
Copy link
Contributor

@bundlerbot r+

@bundlerbot
Copy link
Contributor

📌 Commit 5dace94 has been approved by smellsblue

@bundlerbot
Copy link
Contributor

⌛ Testing commit 5dace94 with merge 0894775...

bundlerbot added a commit that referenced this pull request Jan 30, 2017
@bundlerbot
Auto merge of #138 - olleolleolle:fix/build-on-jruby-with-latest-ruby…
0894775 
…gems, r=smellsblue

Travis: JRuby 9.1.7.0, gem update --system, format the buildfile

This PR fixes #137.

- add whitespace to the file, to make it more readable
- update JRuby to latest stable
- add a `before_install` step to `gem update --system`
@bundlerbot
Copy link
Contributor

💔 Test failed - status-travis

@smellsblue
Copy link
Contributor

@olleolleolle hmmm, it looks like this change removed ruby-head from being an allowed failure somehow...?

@smellsblue
Copy link
Contributor

hmmm, except it seems to have worked fine for the GitHub Travis check...

@olleolleolle
Copy link
Member Author

olleolleolle commented Jan 30, 2017 •
edited
Loading

This was the thing that failed/failed to work:

    with private gems
      behaves like a bundleable project
        successfully bundles
        can bundle with full index
        can bundle with prerelease versions
        can bundle with prerelease versions with full index
[2017-01-30 21:43:19] INFO  going to shutdown ...
[2017-01-30 21:43:19] INFO  WEBrick::HTTPServer#start done.
[2017-01-30 21:43:19] INFO  going to shutdown ...
[2017-01-30 21:43:19] INFO  WEBrick::HTTPServer#start done.
/home/travis/build/bundler/gemstash/vendor/bundle/ruby/2.5.0/gems/rspec-core-3.5.4/exe/rspec: stream closed (IOError)

https://travis-ci.org/bundler/gemstash/jobs/196742905#L1010

@olleolleolle
Copy link
Member Author

@smellsblue But you're right, we should allow it to be almost-successful.

smellsblue
smellsblue reviewed Jan 30, 2017
View reviewed changes
.rubocop.yml
@@ -5,4 +5,6 @@ AllCops:
- bin/**/*
- tmp/**/*
- vendor/**/*
- gemfiles/vendor/**/*
- gemfiles/bin/**/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of combining these into just - gemfiles/**/*?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're confident of the Gemfiles themselves, then sure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERY little content: collapse it!
https://github.com/bundler/gemstash/blob/master/gemfiles/Gemfile.ruby-head

@smellsblue
Copy link
Contributor

@bundlerbot r+

@bundlerbot
Copy link
Contributor

📌 Commit 671b7b7 has been approved by smellsblue

@bundlerbot
Copy link
Contributor

⌛ Testing commit 671b7b7 with merge da1c178...

bundlerbot added a commit that referenced this pull request Jan 31, 2017
@bundlerbot
Auto merge of #138 - olleolleolle:fix/build-on-jruby-with-latest-ruby…
da1c178 
…gems, r=smellsblue

Travis: JRuby 9.1.7.0, gem update --system, format the buildfile

This PR fixes #137.

- add whitespace to the file, to make it more readable
- update JRuby to latest stable
- add a `before_install` step to `gem update --system`
- configure Rubocop to ignore `gemfiles/**/*` as well
@bundlerbot
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: smellsblue
Pushing da1c178 to master...

@bundlerbot bundlerbot merged commit 671b7b7 into rubygems:master Jan 31, 2017
@olleolleolle olleolleolle deleted the fix/build-on-jruby-with-latest-rubygems branch February 1, 2017 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smellsblue smellsblue smellsblue left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to the latest JRuby
3 participants
@olleolleolle @smellsblue @bundlerbot