Configurable options to Sequel.connect #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
force-pushed
the
feature/sequel-config-as-db_connection_options
branch
from
ef3751a to
2951526
Compare
smellsblue
reviewed
Nov 17, 2016
| Valid values | ||
| ------------ | ||
|
|
||
| A valid connection options Hash for the [Sequel.connect](http://sequel.jeremyevans.net/rdoc/files/doc/opening_databases_rdoc.html#label-General+connection+options) method. |
There was a problem hiding this comment.
Could you please move the changes to files in the docs directory into the corresponding files in the man directory? Those end up generating these 😄
smellsblue
reviewed
Nov 17, 2016
| end | ||
| when "postgres", "mysql", "mysql2" | ||
| db = Sequel.connect(config[:db_url]) | ||
| db = Sequel.connect(config[:db_url], config[:db_connection_options]) |
There was a problem hiding this comment.
What do you think about defaulting to the number of puma threads + 1 as @chriseckhardt ended up using? Perhaps { max_connections: config[:puma_threads] + 1 }.merge(config[:db_connection_options])? This would mean adding a new :puma_threads config variable as well.
There was a problem hiding this comment.
Splendid idea, will take it up immediately.
olleolleolle
force-pushed
the
feature/sequel-config-as-db_connection_options
branch
from
af424f5 to
0072dd8
Compare
|
@smellsblue Does it look right to you, now? |
|
@olleolleolle perfect! thanks so much! |
olleolleolle
deleted the
feature/sequel-config-as-db_connection_options
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a configuration key
db_connection_options, which is expected to be a Hash of Sequel.connect options.See #115