Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hidden broken tests merged by mistake because CI failure #1654

Closed
jjbustamante opened this issue Mar 1, 2023 · 2 comments · Fixed by #1657
Closed

Fix hidden broken tests merged by mistake because CI failure #1654

jjbustamante opened this issue Mar 1, 2023 · 2 comments · Fixed by #1657
Labels
status/triage Issue or PR that requires contributor attention. type/chore Issue that requests non-user facing changes.

Comments

@jjbustamante
Copy link
Member

Description

As I reported on #1653 we merged a PR that added tee command to save the result of the test execution in a file. Once we merged this PR the CI stopped notifying when the tests were broken

See the history:

Screenshot 2023-03-01 at 4 05 55 PM

Because of this, after we merged the commits (on the red square above) the CI broke

Screenshot 2023-03-01 at 4 19 58 PM

Locally I verified before all the tests are fine, and after merging this one, we started having the following tests broken

Screenshot 2023-03-01 at 4 22 53 PM

Proposed solution

We need to fix these broken tests.

Additional context

See the PR 1611
@jjbustamante jjbustamante added type/chore Issue that requests non-user facing changes. status/triage Issue or PR that requires contributor attention. labels Mar 1, 2023
@jjbustamante jjbustamante changed the title Fix hide broken test merged by mistake because CI failure Fix hidden broken tests merged by mistake because CI failure Mar 1, 2023
@jjbustamante
Copy link
Member Author

@itsdarshankumar by any chance do you want to work on this?

@jjbustamante jjbustamante mentioned this issue Mar 1, 2023
Closed
2 tasks
@itsdarshankumar
Copy link
Contributor

@itsdarshankumar by any chance do you want to work on this?

Yes sure @jjbustamante, always anytime:)

@jjbustamante jjbustamante mentioned this issue Mar 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/triage Issue or PR that requires contributor attention. type/chore Issue that requests non-user facing changes.
Projects
None yet
Milestone
No milestone
2 participants
@jjbustamante @itsdarshankumar