Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC #0105] pack should support run image extension #1620

Closed
Tracked by #224
natalieparellano opened this issue Feb 2, 2023 · 1 comment · Fixed by #1698
Closed
Tracked by #224

[RFC #0105] pack should support run image extension #1620

natalieparellano opened this issue Feb 2, 2023 · 1 comment · Fixed by #1698
Labels
status/triage Issue or PR that requires contributor attention. type/enhancement Issue that requests a new feature or improvement.

Comments

@natalieparellano
Copy link
Member

natalieparellano commented Feb 2, 2023 •
edited
Loading

When there is a lifecycle that supports run image extension, pack should also support run image extension by:

  • Invoking the extender with -kind run when there are Dockerfiles in <generated>/run (output of the detect phase)

See related lifecycle issue: buildpacks/lifecycle#998
@natalieparellano natalieparellano added type/enhancement Issue that requests a new feature or improvement. status/triage Issue or PR that requires contributor attention. labels Feb 2, 2023
This was referenced Feb 2, 2023
Open
Closed
@natalieparellano
Copy link
Member Author

The implementation for this is going to look a lot like #1547 (which calls the extender for build image extensions)

@natalieparellano natalieparellano mentioned this issue Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/triage Issue or PR that requires contributor attention. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pack should support run image extension on Platform API 0.12 buildpacks/pack
1 participant
@natalieparellano