Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pack inspect when image built with extensions should show the extensions #1486

Closed
Tracked by #224
natalieparellano opened this issue Jul 22, 2022 · 6 comments · Fixed by #1611
Closed
Tracked by #224

pack inspect when image built with extensions should show the extensions #1486

natalieparellano opened this issue Jul 22, 2022 · 6 comments · Fixed by #1611
Assignees
Labels
good first issue A good first issue to get started with. type/enhancement Issue that requests a new feature or improvement.

Comments

@natalieparellano
Copy link
Member

This output should include Extensions if extensions were used:

$  pack inspect hello-extensions
Inspecting image: hello-extensions

REMOTE:
(not present)

LOCAL:

Stack: io.buildpacks.samples.stacks.alpine

Base Image:
  Reference: 17eeba339127d21e62348fe7692bc6ba04f988be690d0cecd249e940efb90141
  Top Layer: sha256:ee08c026c070425ca3aa6e49e07338ab4eee589f7ce35bb921832b6013d39f49

Run Images:
  cnbs/sample-stack-run:alpine

Buildpacks:
  ID                              VERSION        HOMEPAGE
  samples/hello-extensions        0.0.1          https://github.com/buildpacks/samples/tree/main/buildpacks/hello-extensions

Processes:
  TYPE                  SHELL        COMMAND        ARGS
  curl (default)                     curl           --version
@natalieparellano natalieparellano added type/enhancement Issue that requests a new feature or improvement. status/triage Issue or PR that requires contributor attention. extensions-phase-1 good first issue A good first issue to get started with. labels Jul 22, 2022
@jromero jromero removed the status/triage Issue or PR that requires contributor attention. label Aug 16, 2022
@jalajk24
Copy link

hey @natalieparellano, i am interested to contribute in this issue could you plz drop some insight as i am new to open source and this will be my first project

@natalieparellano
Copy link
Member Author

@jalajk24 it would be awesome to get your help here!

At a high level, when inspecting the image, pack:

  • Reads the io.buildpacks.build.metadata label from the image
  • Parses the data from that label - see here for how it is done for buildpacks
  • Renders the data - see here for how we update buildpack info and here for how we display it in a "readable" format

I think the changes required here would largely involve copying what we have for buildpacks and updating it so that it's valid for extensions.

It's worth noting - this open PR for platform 0.10 support introduces some changes to the way inspect image is working (updating the lifecycle library code that is imported) and you probably want those changes to land before introducing others. I'm actively working to fix up the open PR today and hopefully it will be merged soon. If you wanted to branch off platform-0.10 for now I think that would be okay as the remaining stuff that I'm fixing won't intersect with the inspect image code.

Thanks again for your help and please don't hesitate to reach out with any further questions!

@Abhi149209
Copy link

hey , can I contribute to this issue ?
I am begineer but I can resolve this

@Abhi149209
Copy link

tell me the setup , as I could not find that

@natalieparellano
Copy link
Member Author

@jalajk24 were you still interested in taking this up? Please let us know... otherwise @Abhi149209 you are welcome to claim it - https://github.com/buildpacks/pack/blob/main/DEVELOPMENT.md will have useful information for configuring your setup.

@jalajk24
Copy link

@natalieparellano yes i am interested in this plz assign it to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A good first issue to get started with. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
4 participants