Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: Lifecycle should run hooks’ bin/build #714

Closed
natalieparellano opened this issue Sep 17, 2021 · 2 comments
Closed

Spike: Lifecycle should run hooks’ bin/build #714

natalieparellano opened this issue Sep 17, 2021 · 2 comments

Comments

@natalieparellano
Copy link
Member

natalieparellano commented Sep 17, 2021

Broken out from #709

(4) Lifecycle should run hooks’ bin/build

Hooks may be executed in parallel
For each hook:

  • <layers> is replaced by <output>
  • If a hook is missing bin/build, the hook root should be treated as a pre-populated directory
  • Output files should be validated:
    • build.toml:
      • May include args table
    • launch.toml:
      • May include args table
      • Must not include processes or slices

(5) Lifecycle should provide Dockerfiles output by hooks to subsequent phases

The files should probably be copied to a volume (/layers? Does this depend on buildpacks/rfcs#145 ?)

@cmoulliard
Copy link

Hooks

That should b great to have a sample about what a hooked project will look like (+ Dockerfile, Hook TOML, ...)

  1. Non hooked
builders
└── maven-jvm
    └── builder.toml
 
buildpacks/maven
├── bin
│   ├── build
│   └──detect
└── buildpack.toml
  1. Hooked project
    ???

@natalieparellano
Copy link
Member Author

Completed as part of #709 (see comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants