-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document: "Check Linked Containers" config setting #105
Comments
Hi @grrowl 👋🏻It's really not designed to be used, it's an internal setting for testing. What are you trying to accomplish? |
Specifically we have two containers in our compose — selenium/hub and and selenium/node-chrome — who log to stdout and which we need the output for (to debug selenium, natch) We're successful uploading log artifacts from containers which write to files in mapped volumes; but I can't find a solution for these selenium-based ones which only write to stdout |
The "check linked containers" setting is supposed to be the default behaviour, which in the case of a failure should grab the log output from all linked containers and upload the logs as assets. We've just fixed a bug that stopped this behaviour from running (see #103), which I suspect you might be running into. Beyond that, we've been talking about ways to show logging from all linked containers in #98. I'm going to get out a new release in the next few minutes @grrowl, hopefully it should fix the issue for you until we have a good solution to showing log output from multiple containers. |
Glorious, thank you! I'll test imminently and follow up |
Confirmed Thanks for the excellent and speedy reply @lox! |
Please document how config option
CHECK_LINKED_CONTAINERS
(aka envBUILDKITE_PLUGIN_DOCKER_COMPOSE_CHECK_LINKED_CONTAINERS
) should be used, as seen in https://github.com/buildkite-plugins/docker-compose-buildkite-plugin/blob/master/hooks/commands/run.sh#L98I've tried defining the env var in
pipeline.yml
(in top-level keyenv
and insteps.command.plugins.docker-compose#v1.8.3.env
) but each seemed to have no effect.The text was updated successfully, but these errors were encountered: