Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document: "Check Linked Containers" config setting #105

Closed
grrowl opened this issue Mar 7, 2018 · 5 comments
Closed

Document: "Check Linked Containers" config setting #105

grrowl opened this issue Mar 7, 2018 · 5 comments

Comments

@grrowl
Copy link

grrowl commented Mar 7, 2018

Please document how config option CHECK_LINKED_CONTAINERS (aka env BUILDKITE_PLUGIN_DOCKER_COMPOSE_CHECK_LINKED_CONTAINERS) should be used, as seen in https://github.com/buildkite-plugins/docker-compose-buildkite-plugin/blob/master/hooks/commands/run.sh#L98

I've tried defining the env var in pipeline.yml (in top-level key env and in steps.command.plugins.docker-compose#v1.8.3.env) but each seemed to have no effect.

@grrowl grrowl changed the title Document: Linked Containers config setting Document: "Check Linked Containers" config setting Mar 7, 2018
@lox
Copy link
Contributor

lox commented Mar 7, 2018

Hi @grrowl 👋🏻It's really not designed to be used, it's an internal setting for testing. What are you trying to accomplish?

@grrowl
Copy link
Author

grrowl commented Mar 7, 2018

Specifically we have two containers in our compose — selenium/hub and and selenium/node-chrome — who log to stdout and which we need the output for (to debug selenium, natch)

We're successful uploading log artifacts from containers which write to files in mapped volumes; but I can't find a solution for these selenium-based ones which only write to stdout

@lox
Copy link
Contributor

lox commented Mar 7, 2018

The "check linked containers" setting is supposed to be the default behaviour, which in the case of a failure should grab the log output from all linked containers and upload the logs as assets.

We've just fixed a bug that stopped this behaviour from running (see #103), which I suspect you might be running into.

Beyond that, we've been talking about ways to show logging from all linked containers in #98.

I'm going to get out a new release in the next few minutes @grrowl, hopefully it should fix the issue for you until we have a good solution to showing log output from multiple containers.

@grrowl
Copy link
Author

grrowl commented Mar 7, 2018

Glorious, thank you! I'll test imminently and follow up

@grrowl
Copy link
Author

grrowl commented Mar 7, 2018

Confirmed docker-compose#v1.8.4 fixes the issue. Each composed container's logs are uploaded as artifacts, and the main app's log is output in the Buildkite UI.

Thanks for the excellent and speedy reply @lox!

@grrowl grrowl closed this as completed Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants