stop monkeyPatching fetch API

[lifeiscontent]

No description provided.

[bengourley]

It's the only way to track network requests as breadcrumbs, since the browser doesn't offer an event for it.

You can switch this off with the networkBreadcrumbsEnabled option if it is having undesirable side-effects.

[sassomedia]

@bengourley The networkBreadcrumbsEnabled options does not work, network-breadcrumbs.js is still loaded. What can be done about this? 3rd-party libraries really should not alter native objects.

Using v6 of Bugsnag, btw.

[xljones]

@sassomedia, in v7 this option looks slightly different: https://docs.bugsnag.com/platforms/javascript/configuration-options/#enabledbreadcrumbtypes

Use:

Bugsnag.start({ 
  enabledBreadcrumbTypes: ['error', 'log', 'navigation', 'user']
})

Omitting 'request' from this list.

[sassomedia]

@xander-jones Thanks for the quick reply, although I don't see this working either. v6 used to have a bugsnagClient setup and that's basically what we have, simplified example here: https://codepen.io/sassomedia/pen/GRZegrB.

That console.log(fetch) in the example should output ƒ fetch() { [native code] } but I'm always getting the monkey-patch. Is there something else I'm missing? Thanks!

[xljones]

@sassomedia, sorry made an error in my comment above, this is for v7 🙈. I've amended my comment above. For v6, this would be the following option: https://docs.bugsnag.com/platforms/javascript/legacy/configuration-options/#networkbreadcrumbsenabled-browser-only.

I think the issue you're seeing is that you're changing the Bugsnag config after instantiating Bugsnag, so at this point fetch() has already been patched.

If you use the following, you can use Bugsnag, and we won't be patching fetch():

var bugsnagClient = bugsnag({
  apiKey: 'cdd848e5d2da0a26bda6f31a42452428',
  networkBreadcrumbsEnabled: false
});
window.bugsnagClient = bugsnagClient;
console.log(fetch);

Results in:

ƒ fetch() { [native code] }

[sassomedia]

@xander-jones Ah ok, yes that makes sense. Works for me, thanks a bunch!