From 81e4ad9260c9b016dc1fac03e12f8ffc0cb06689 Mon Sep 17 00:00:00 2001
From: Steve Kirkland-Walton <steve@bugsnag.com>
Date: Mon, 13 Nov 2023 16:55:29 +0000
Subject: [PATCH] Consistently fail-fast e2e test scenarios

---
 .buildkite/pipeline.full.yml |  6 ++++++
 .buildkite/pipeline.yml      | 34 ++++++++++++++++++----------------
 2 files changed, 24 insertions(+), 16 deletions(-)

diff --git a/.buildkite/pipeline.full.yml b/.buildkite/pipeline.full.yml
index d4eea6b16..7f5571300 100644
--- a/.buildkite/pipeline.full.yml
+++ b/.buildkite/pipeline.full.yml
@@ -32,6 +32,7 @@ steps:
           - "--device=IOS_15"
           - "--no-tunnel"
           - "--aws-public-ip"
+          - "--fail-fast"
     concurrency: 25
     concurrency_group: 'bitbar'
     concurrency_method: eager
@@ -56,6 +57,7 @@ steps:
           - "--device=IOS_15"
           - "--no-tunnel"
           - "--aws-public-ip"
+          - "--fail-fast"
     concurrency: 25
     concurrency_group: 'bitbar'
     concurrency_method: eager
@@ -268,6 +270,7 @@ steps:
           - "--farm=bs"
           - "--device=IOS_15"
           - "--appium-version=1.21.0"
+          - "--fail-fast"
           - "features/app_hangs.feature"
     concurrency: 5
     concurrency_group: 'browserstack-app'
@@ -296,6 +299,7 @@ steps:
           - "--farm=bs"
           - "--device=IOS_14"
           - "--appium-version=1.21.0"
+          - "--fail-fast"
           - "features/app_hangs.feature"
     concurrency: 5
     concurrency_group: 'browserstack-app'
@@ -324,6 +328,7 @@ steps:
           - "--farm=bs"
           - "--device=IOS_13"
           - "--appium-version=1.21.0"
+          - "--fail-fast"
           - "features/app_hangs.feature"
     concurrency: 5
     concurrency_group: 'browserstack-app'
@@ -352,6 +357,7 @@ steps:
           - "--farm=bs"
           - "--device=IOS_12"
           - "--appium-version=1.21.0"
+          - "--fail-fast"
           - "features/app_hangs.feature"
     concurrency: 5
     concurrency_group: 'browserstack-app'
diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml
index ead95af6d..10b2f567d 100644
--- a/.buildkite/pipeline.yml
+++ b/.buildkite/pipeline.yml
@@ -376,6 +376,7 @@ steps:
           - "--farm=bs"
           - "--device=IOS_16"
           - "--appium-version=1.21.0"
+          - "--fail-fast"
           - "features/app_hangs.feature"
     concurrency: 5
     concurrency_group: 'browserstack-app'
@@ -523,14 +524,14 @@ steps:
         run: cocoa-maze-runner
         service-ports: true
         command:
-          - --app=@/app/build/ipa_url_bs.txt
-          - --farm=bs
-          - --device=IOS_17
-          - --appium-version=1.18.0
-          - --a11y-locator
-          - --fail-fast
-          - --exclude=features/[e-z].*.feature$
-          - --order=random
+          - "--app=@/app/build/ipa_url_bs.txt"
+          - "--farm=bs"
+          - "--device=IOS_17"
+          - "--appium-version=1.18.0"
+          - "--a11y-locator"
+          - "--fail-fast"
+          - "--exclude=features/[e-z].*.feature$"
+          - "--order=random"
     concurrency: 25
     concurrency_group: 'browserstack-app'
     concurrency_method: eager
@@ -554,14 +555,14 @@ steps:
         run: cocoa-maze-runner
         service-ports: true
         command:
-          - --app=@/app/build/ipa_url_bs.txt
-          - --farm=bs
-          - --device=IOS_17
-          - --appium-version=1.18.0
-          - --a11y-locator
-          - --fail-fast
-          - --exclude=features/[a-d].*.feature$
-          - --order=random
+          - "--app=@/app/build/ipa_url_bs.txt"
+          - "--farm=bs"
+          - "--device=IOS_17"
+          - "--appium-version=1.18.0"
+          - "--a11y-locator"
+          - "--fail-fast"
+          - "--exclude=features/[a-d].*.feature$"
+          - "--order=random"
     concurrency: 25
     concurrency_group: 'browserstack-app'
     concurrency_method: eager
@@ -589,6 +590,7 @@ steps:
           - "--farm=bs"
           - "--device=IOS_11_0_IPHONE_8_PLUS"
           - "--appium-version=1.16.0"
+          - "--fail-fast"
           - "features/barebone_tests.feature"
     concurrency: 5
     concurrency_group: 'browserstack-app'