Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hard-code @com_google_protobuf//:protoc #74

Open
alexeagle opened this issue May 29, 2024 · 1 comment
Open

Don't hard-code @com_google_protobuf//:protoc #74

alexeagle opened this issue May 29, 2024 · 1 comment

Comments

@alexeagle
Copy link
Contributor

According to bazelbuild/rules_proto#213 users of Bazel 7 can now ask Bazel to resolve protoc from a toolchain.

There are two spots at HEAD:

 "_protoc": attr.label(
    default = "@com_google_protobuf//:protoc",
    executable = True,
    cfg = "exec",
),
@momilo
Copy link

momilo commented Aug 29, 2024

This change would be highly appreciated. We have recently migrated to using Aspect Build's kindly-provided pre-compiled protoc toolchain (toolchains_protoc) (which seems to be the recommended approach since the new versions of rules_go, and deprecation of rules_proto) , which has sped-up all our processed significantly.

Relying on rules_buf would force us to re-introduce compilation of protoc from scratch, which is something we cannot really afford to do (any more).

It would be great if we could leverage the registered toolchain instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants