Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back grpc c++ support #99

Closed
bplotnick opened this issue Sep 10, 2018 · 2 comments
Closed

Add back grpc c++ support #99

bplotnick opened this issue Sep 10, 2018 · 2 comments
Labels
Bug Reports and/or fixes a bug C++ C++ language support

Comments

@bplotnick
Copy link

We used to be able to pass in use_grpc_plugin to pgv_cc_proto_library until #92. This is useful for c++ applications talking to Envoy.

You can kind of see a use-case in this PR that i let fall by the wayside: https://github.com/envoyproxy/envoy/pull/3857/files

It'd be nice to have this back in some way.

@rodaine rodaine added Bug Reports and/or fixes a bug C++ C++ language support labels Sep 11, 2018
@rodaine
Copy link
Member

rodaine commented Sep 11, 2018

@sesmith177 is this related to your bazel changes, perhaps?

@sesmith177
Copy link
Contributor

Yep, it looks like use_grpc_plugin was handled in the protobuf.bzl here, and when we broke the dependency on that file, the functionality did not make it over

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Reports and/or fixes a bug C++ C++ language support
Projects
None yet
Development

No branches or pull requests

4 participants