Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages with workspaces (e.g. buf push) #895

Closed
amckinney opened this issue Jan 29, 2022 · 1 comment
Closed

Improve error messages with workspaces (e.g. buf push) #895

amckinney opened this issue Jan 29, 2022 · 1 comment
Labels
Cleanup Cleanup tasks

Comments

@amckinney
Copy link
Contributor

We've seen a few users struggle with the fact that their module needs to define all of its dependencies in a buf.lock before it can be pushed to the BSR. This is described in the tour, but it's still not clear from the error message. For example, from Slack:

$ buf push
Failure: oqton/services/storage/v1/service.proto:6:8:oqton/schema/v1/method.proto: does not exist

In this case, the user's module successfully built with a buf.work.yaml in a parent directory, but it couldn't be pushed since it wasn't expressed in this module's buf.lock. Let's detect this and return a better error that explains that the dependency was found and that they just need to run buf mod update.

Note that this relates to some of the other workspace-level operations described here.

@amckinney amckinney added P1 Cleanup Cleanup tasks labels Jan 29, 2022
@bufdev bufdev removed the P1 label Feb 2, 2023
@doriable
Copy link
Member

We now have v2 buf.yaml configurations that configures the entire workspace in a single top-level buf.yaml and defines a single set of dependencies for the entire workspace, so managing dependencies for individual modules in the workspace is no longer a concern. This also enables pushing for the entire workspace :) So closing this for now since this concern can be addressed by migrating to v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Cleanup tasks
Projects
None yet
Development

No branches or pull requests

3 participants