Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise exception when --max-scaling-factor is set to 0 #18

Closed
btschwertfeger opened this issue Apr 16, 2023 · 0 comments · Fixed by #9
Closed

Raise exception when --max-scaling-factor is set to 0 #18

btschwertfeger opened this issue Apr 16, 2023 · 0 comments · Fixed by #9
Assignees
@btschwertfeger
Labels
Should Something that should be implemented somewhere in the future
Milestone
Release v1.9.0

Comments

@btschwertfeger
Copy link
Owner

Is your feature request related to a problem? Please describe.
There should be an error if the maximum scaling factor is set to zero since this could break the computation for non-stochastic variables.
@btschwertfeger btschwertfeger added the Should Something that should be implemented somewhere in the future label Apr 16, 2023
@btschwertfeger btschwertfeger added this to the Release v1.8.2 milestone Apr 16, 2023
@btschwertfeger btschwertfeger self-assigned this Apr 16, 2023
@btschwertfeger btschwertfeger mentioned this issue Apr 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@btschwertfeger btschwertfeger

Labels
Should Something that should be implemented somewhere in the future
Projects
None yet
Milestone
Release v1.9.0
Development

Successfully merging a pull request may close this issue.

Add Unit Tests; Simplify the Installation; Create the CI btschwertfeger/BiasAdjustCXX
1 participant
@btschwertfeger