-
Notifications
You must be signed in to change notification settings - Fork 0
Implement Chain normalization by mixed canonization #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @mofeing comments, and it is a good idea to make that these kinds of functions work in-place. Also, the idea of normalizing in this manner is to take the Tensor
that is not in either left nor right canonical form (the one in centersite
), get its norm
(since it is the one that contains the weights), and normalize by this value the entire Chain
.
Check the changes. I am not sure if I have to do something else other than normalizing the centersite tensor. Doing it this way, the complete |
You're having a format problem. Please install |
Co-authored-by: Jofre Vallès Muns <61060572+jofrevalles@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
==========================================
- Coverage 75.00% 73.55% -1.45%
==========================================
Files 8 8
Lines 436 450 +14
==========================================
+ Hits 327 331 +4
- Misses 109 119 +10 ☔ View full report in Codecov by Sentry. |
Closes #18