-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide tests for Rust 1.4 #2
Comments
Wow! I'm glad you are using it. Maybe this will inspire me to whip it into shape. |
Let me provide you with our experience with ctrs then :) We use it to "verify" our parser. That is, we check that every file parses somehow. We do not verify that the parse tree is right, because we don't have a correct answer to compare with. In general I don't think it is feasible to compare concrete parse trees, because they will be different in details. It might be possible to compare lexical structure though. @winger even wrote a comparison tool: winger/intellij-rust@62e5d81. We don't use it now because of the difficulties of maintaining rust subproject within Java/Kotlin codebase. |
@matklad I'm in the process of rewriting the python test driver as a cargo project (it will use build scripts to generate rust |
I don't know :) It should not matter much, because from Java point of view it will be just different external processes. Rust might be sightly easier to distribute: if you are messing with ctrs then most likely you have cargo installed, but, if you are using Windows, Python may be absent. |
Updated for 1.4. |
FYI: we've drop ctrs from IntelliJ Rust test suite and test our parser on the compiler and standard library sources instead. The main reason is that we must support nightly features, because the standard library uses them. |
@matklad Thanks for the update. Sorry I haven't maintained this thing. |
There is at least one language change that is currently not covered by tests: rust-lang/rust#27451
FYI: we are using ctrs in tests in https://github.com/alexeykudinkin/intellij-rust and it helps us a lot :)
The text was updated successfully, but these errors were encountered: