Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Small issue on TODO list and return #43

Closed
Shuunen opened this issue Mar 22, 2016 · 5 comments
Closed

Small issue on TODO list and return #43

Shuunen opened this issue Mar 22, 2016 · 5 comments
Labels

Comments

@Shuunen
Copy link

Shuunen commented Mar 22, 2016

Hi,

Here an example of the behaviour of Abricotine when hitting "Enter" at the end of a TODO line, it does not create another todo on the new line.

gif

Then as a second issue, when selecting multiple lines and toggling TODO style, it mess up with the star character.

@brrd brrd added the bug label Mar 22, 2016
@brrd
Copy link
Owner

brrd commented Mar 22, 2016

1st issue: we need a custom rewrite of CodeMirror's continuelist.js plugin that would support todolists.

2nd issue is probably a bug somewhere in Abricotine's cm-extend-markdown.js

@brrd
Copy link
Owner

brrd commented Mar 16, 2017

From @jacobmischka (#161)

Interestingly, this works out of the box if you use - for bullets intead of *.

peek 2017-03-15 23-19

I didn't notice this. It's actually already supported in CodeMirror: https://github.com/codemirror/CodeMirror/blob/master/addon/edit/continuelist.js#L14-L15

Actually the * [ ] syntax is not clearly mantionned in Github flavored markdown even if Github supports it. I think we should use the recommended - [ ] syntax in Abricotine. And by the way I'll PR the support for * [ ] in CodeMirror.

@jacobmischka
Copy link
Contributor

jacobmischka commented Mar 16, 2017

I believe CodeMirror actually does support it, unless I'm terrible at reading regexes. Both listRE and emptyListRE seem to include the boxes with *|-. I couldn't figure out why the * didn't work, though.

Edit: Whoops I didn't see that you linked to that same place in your comment too. Can you see why * isn't working by looking at those regexes?

Edit: Oh, there aren't any parens around the *|- in either of them. Is that a bug?

Final edit: Oh lol, no that * is a modifier, not a character, nevermind. Man I hate regexes.

@brrd
Copy link
Owner

brrd commented Mar 16, 2017

@jacobmischka This may answer your question: codemirror/codemirror5@9c9a4cb 😉

@jacobmischka
Copy link
Contributor

Ha yeah, the coincidental *|- confused me. I just woke up let's blame that 😪

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants