Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict mode? #37

Closed
jprichardson opened this issue Sep 15, 2018 · 13 comments · Fixed by #41
Closed

Strict mode? #37

jprichardson opened this issue Sep 15, 2018 · 13 comments · Fixed by #41

Comments

@jprichardson
Copy link
Member

Node v9.9.0 introduced some changes into the assert package. Most notably the introduction of strict mode.

Would you accept a PR introducing this new functionality and bringing this module up to date?

@jprichardson
Copy link
Member Author

If it simplifies the maintenance burden on your end @defunctzombie - how would you feel about moving this repo to the browserify org?

@defunctzombie
Copy link
Contributor

@jprichardson I'd be open to that (clearly I have let this module go by the wayside) - what would that require logistically?

@calvinmetcalf
Copy link
Collaborator

I think you'd have to grant ownership of the project to somebody who is an admin in the browserify org, which would include both me and @jprichardson

@defunctzombie
Copy link
Contributor

@calvinmetcalf you are already listed as a collaborator on the repo - is there some other action that "grants ownership" ?

@calvinmetcalf
Copy link
Collaborator

i just invited you into the browserify org

@defunctzombie
Copy link
Contributor

@calvinmetcalf Should I see a notification somewhere for that? I received no email about it.

@jprichardson
Copy link
Member Author

I tried to invite you again @defunctzombie. Looks like you were invited by Substack awhile ago. See if you can visit this link: https://github.com/organizations/browserify/settings/profile and if there is something about accepting the invite.

@defunctzombie
Copy link
Contributor

@jprichardson I get a 404 when I visit that link.

@jprichardson
Copy link
Member Author

@defunctzombie I canceled the invite, and then invited you again. Any email now...?

@defunctzombie
Copy link
Contributor

@jprichardson @calvinmetcalf repository transferred. Feel free to remove me from the browserify organization.

@kuraga
Copy link

kuraga commented Sep 24, 2018

Wow! I've come here at the right moment... 😄 👍

@kuraga
Copy link

kuraga commented Sep 24, 2018

@jprichardson It would be very nice if we'll get a NodeJS-compatibility. I.e. commonjs-assert x.y is compatible with NodeJS x.y!

@fabiosantoscode
Copy link

Any updates on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants