Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take a deeper look at odeChamber #63

Open
cpaniaguam opened this issue Nov 1, 2022 · 1 comment · Fixed by #159
Open

Take a deeper look at odeChamber #63

cpaniaguam opened this issue Nov 1, 2022 · 1 comment · Fixed by #159
Assignees
@cpaniaguam

Comments

@cpaniaguam
Copy link
Member

Can the structure of the function be simplified?
@cpaniaguam cpaniaguam self-assigned this Nov 1, 2022
@cpaniaguam
Copy link
Member Author

@CallieHsu, I remember we started using a Silicic and Mafic types to get specialized functions for each. Was this implemented for odeChamber? If not, we should consider doing this for this function.

@cpaniaguam cpaniaguam mentioned this issue Dec 9, 2022
Closed
@CallieHsu CallieHsu linked a pull request Dec 13, 2022 that will close this issue
Use composition type for chamber & other funcs #159
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpaniaguam cpaniaguam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use composition type for chamber & other funcs brown-ccv/Chamber.jl
1 participant
@cpaniaguam