Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refacter IC_Finder #161

Closed
CallieHsu opened this issue Dec 13, 2022 · 1 comment · Fixed by #188
Closed

refacter IC_Finder #161

CallieHsu opened this issue Dec 13, 2022 · 1 comment · Fixed by #188

Comments

@CallieHsu
Copy link
Collaborator 

    Is this function also defined in L248? If so, consider defining it outside of the scope this function.

Originally posted by @cpaniaguam in #159 (comment)
@CallieHsu
Copy link
Collaborator Author

Removed duplicate code in IC_Finder
https://github.com/CallieHsu/Chamber.jl/blob/ef17b27ff9128f7c0d62ea0ba7e2fccc9537f6d8/src/IC_finder.jl#L109

@CallieHsu CallieHsu linked a pull request Apr 17, 2023 that will close this issue
161 refacter ic finder #188
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

161 refacter ic finder brown-ccv/Chamber.jl
1 participant
@CallieHsu