Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve augur_align performance #108

Closed
dpark01 opened this issue Jun 10, 2020 · 3 comments · Fixed by #132
Closed

improve augur_align performance #108

dpark01 opened this issue Jun 10, 2020 · 3 comments · Fixed by #132
Assignees

Comments

@dpark01
Copy link
Member

dpark01 commented Jun 10, 2020

Possibly replace augur align invocation with our own mafft-based wrappers that take advantage of recent optimizations. Keep existing WDL task for augur align (in case we want it later) but add a new task (or modify an existing one) to interhost.wdl and use that instead in the main nextstrain workflow(s)

@tomkinsc
Copy link
Member

One question is whether we should pursue changes to augur upstream to add something like a --consider_conserved param to augur align that toggles a code path with mafft --addfragments and --keeplength.

@dpark01
Copy link
Member Author

dpark01 commented Jun 11, 2020

Well one question is whether augur align does much other than a specific incantation of mafft. If it doesn't, maybe the best path is just to call mafft ourselves. But if it's doing something special and nextstrainy, pursuing upstream changes may make sense.

@dpark01
Copy link
Member Author

dpark01 commented Jun 11, 2020

Quick note, #112 tangentially addressed this a bit by throwing some more CPU at it (since mafft appears to make good use of available cores).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants