Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Bluesky profile link (SCP-5876) #2182

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

bistline
Copy link
Contributor

@bistline bistline commented Dec 12, 2024

BACKGROUND & CHANGES

This update adds a link to the SCP Bluesky profile, as well as updating our DNS to use our hostname as the username.

New social media icon for Blueksy:
Screenshot 2024-12-12 at 12 21 13 PM

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.15%. Comparing base (867415d) to head (2c2cf0a).
Report is 19 commits behind head on development.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2182      +/-   ##
===============================================
- Coverage        70.18%   70.15%   -0.03%     
===============================================
  Files              332      332              
  Lines            28150    28173      +23     
  Branches          2467     2368      -99     
===============================================
+ Hits             19757    19765       +8     
- Misses            8246     8261      +15     
  Partials           147      147              

see 11 files with indirect coverage changes

@bistline bistline requested review from eweitz and jlchang December 12, 2024 18:20
Copy link
Contributor

@jlchang jlchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out the new footer locally, looks great! Love the new, verified handle too!

@bistline bistline added the build failure: false positive Build error confirmed as false positive. E.g. upstream service has a problem. label Dec 12, 2024
Copy link
Member

@eweitz eweitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Nit, non-blocking: maybe put the Bluesky icon right beside the Twitter icon?

@bistline
Copy link
Contributor Author

Nice! Nit, non-blocking: maybe put the Bluesky icon right beside the Twitter icon?
Done!

Screenshot 2024-12-12 at 3 40 28 PM

@bistline bistline merged commit a4569bc into development Dec 17, 2024
4 of 5 checks passed
@github-actions github-actions bot deleted the jb-bluesky-link branch December 17, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build failure: false positive Build error confirmed as false positive. E.g. upstream service has a problem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants