Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More consistent stopping of multiprocessing workers #352

Open
ndiamant opened this issue Jul 2, 2020 · 0 comments
Open

More consistent stopping of multiprocessing workers #352

ndiamant opened this issue Jul 2, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@ndiamant
Copy link
Contributor

ndiamant commented Jul 2, 2020

What
Make TensorGenerator or test_train_valid_generators a context manager, so that no matter what the multiprocessing workers are always shut down.

Why
It's annoying to manually kill workers if a job fails, and could get in the way of multiple TensorGenerator jobs.

How
Make TensorGenerator or test_train_valid_generators a context manager that manages the workers resource.

Acceptance Criteria
Workers never outlast their TensorGenerator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ndiamant