From 74885eff73ddb2f6a3df9d89be4a7b32f4b741f6 Mon Sep 17 00:00:00 2001 From: Adam Nichols Date: Fri, 27 Sep 2024 09:34:31 -0400 Subject: [PATCH] WX-1835 Silence quota exhaustion logging when empty (#7561) --- .../cromwell/backend/standard/GroupMetricsActor.scala | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/backend/src/main/scala/cromwell/backend/standard/GroupMetricsActor.scala b/backend/src/main/scala/cromwell/backend/standard/GroupMetricsActor.scala index 6a0626c281..f7c09209a8 100644 --- a/backend/src/main/scala/cromwell/backend/standard/GroupMetricsActor.scala +++ b/backend/src/main/scala/cromwell/backend/standard/GroupMetricsActor.scala @@ -43,10 +43,11 @@ class GroupMetricsActor(engineDbInterface: EngineSqlDatabase, case LogQuotaExhaustedGroups => getQuotaExhaustedGroups() onComplete { case Success(quotaExhaustedGroups) => - log.info( - s"Hog groups currently experiencing quota exhaustion: ${quotaExhaustedGroups.length}. Group IDs: [${quotaExhaustedGroups.toList - .mkString(", ")}]." - ) + if (quotaExhaustedGroups.nonEmpty) + log.info( + s"Hog groups currently experiencing quota exhaustion: ${quotaExhaustedGroups.length}. Group IDs: [${quotaExhaustedGroups.toList + .mkString(", ")}]." + ) case Failure(exception) => log.info( s"Something went wrong when fetching quota exhausted groups for logging. Will retry in ${loggingInterval