Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection of enums annotated with Argument are not showing possible values #142

Open
magicDGS opened this issue Aug 5, 2018 · 2 comments
Assignees

Comments

@magicDGS
Copy link
Contributor

magicDGS commented Aug 5, 2018

If a class with an argument in the form:

...
public static enum Opt { ONE, TWO };
@Argument
public List<Opt> list = new ArrayList<>;

Does not show in the cli nor docgen the options in the form of other arguments such as Possible values: {ONE, TWO}.

@cmnbroad
Copy link
Collaborator

cmnbroad commented Nov 6, 2018

@bhanugandham I think this is a really good ticket to start on. I just tried it with both GATK master (the command line help output looks correct, but the docgen output doesn't), and also directly in Barclay master using the docgen test (the output looks correct). As I noted earlier, GATK doesn't have the current Barclay code, which I think explains why it works in Barclay but not GATK.

So although I think its already fixed, we don't have any tests for this case, so it would be a good to verify it and add tests to cover it.

@bhanugandham
Copy link

Thanks Chris I will look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants