Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cellbender failing on sample with ~150 cells #169

Closed
ktpolanski opened this issue Nov 28, 2022 · 3 comments
Closed

cellbender failing on sample with ~150 cells #169

ktpolanski opened this issue Nov 28, 2022 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ktpolanski
Copy link

Hello,

Sometimes you're stuck with a sample which doesn't have a lot going on. This is one of those. This is what the knee plot looks like for it:

image

I fed it into a relatively recent cellbender (installed on 08.06.2021, so only a few commits behind master), and got the following strange error about some tensor being empty:

cbk.5277079.txt

Is there anything that can be done to salvage this sample? Thanks and sorry for the trouble.

@sjfleming
Copy link
Member

sjfleming commented Nov 29, 2022

@ktpolanski you found a bug! Hmmm, I will have to keep that one in mind. The issue is that I try to compute an "average size" for cells on the first pass through the encoder neural network... but in this sample, by chance, there were actually no "cells" in the first minibatch. So I will need to fix this.

But for now, I bet there's something you can do.

Try this:

cellbender remove-background \
    --input TransTHY8814436/raw.h5 \
    --output TransTHY8814436/TransTHY8814436_knee.h5 \
    --expected-cells 100 \
    --total-droplets-included 1000 \
    --fpr 0.01 0.05 0.1 \
    --cuda

(The smaller --total-droplets-included will hopefully (1) let CellBender know the prior on empty droplet counts should be larger than it was estimating before, and (2) it will increase the ratio of cells to empties in each minibatch, hopefully side-stepping the bug.)

@sjfleming sjfleming self-assigned this Nov 29, 2022
@sjfleming sjfleming added the bug Something isn't working label Nov 29, 2022
@sjfleming sjfleming added this to the v0.3.0 milestone Nov 29, 2022
@ktpolanski
Copy link
Author

Thanks for the suggestion! Our GPU queues are super congested and the job is still stuck as pending, I'll let you know once it goes through.

@sjfleming
Copy link
Member

Hopefully these kinds of things are solved in v0.3.0 and much smoother for users.

Closed by #238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants