Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors encountered during prerender do not exit the process with failure code #33

Closed
gryphonmyers opened this issue Apr 9, 2021 · 0 comments

Comments

@gryphonmyers
Copy link
Contributor

Reproduction Steps:

  1. Execute prerender command for a site that throws an error in a used prerender hook, followed by another command e.g. npm run prerender && echo 'hi'
  2. Observe that after the error is thrown and the prerender process fails, the second command is executed.

Expected Results:
Any error encountered during prerender should immediately exit the process via process.exit(1) to prevent operations downstream (e.g. deploying a broken site).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant