Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ring::polyfill::fill_from_slice with use of <[T]>::clone_from_slice() #136

Closed
briansmith opened this issue Mar 3, 2016 · 3 comments

Comments

@briansmith
Copy link
Owner

See http://blog.rust-lang.org/2016/03/02/Rust-1.7.html. <[T]>::clone_from_slice() was stabilized in Rust 1.7, which is now the minimum supported version in ring.

Note that clone_from_slice may not actually get optimized as well as fill_from_slice does. If that is found to be the case, then we'll have to wait for rust-lang/rust#31755 to be resolved.

@briansmith
Copy link
Owner Author

Thanks! Landed in 7cdaeeb.

@Ms2ger
Copy link
Contributor

Ms2ger commented Mar 8, 2016

Actually landed in 43af354.

@briansmith
Copy link
Owner Author

I am going to revert this. Although it didn't seem to affect crypto_bench numbers, it did negatively affect the amount of time Travis CI debug builds take and now some of them are timing out:
https://travis-ci.org/briansmith/ring/builds/114456084.

Looks like we'll have to wait for copy_from_slice to become stable. The ring issue for switching to copy_from_slice is #141.

Thanks for the patch though! Sorry I didn't notice this before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants