diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f6cdf73a65..3e7af62a51 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -284,14 +284,12 @@ jobs: cargo +${{ matrix.rust_channel }} test -vv --target=${{ matrix.target }} ${{ matrix.cargo_options }} ${{ matrix.features }} ${{ matrix.mode }} # Check that all the needed symbol renaming was done. - # TODO: Do this check on Windows too. - - if: ${{ (matrix.target != 'aarch64-apple-ios' || matrix.rust_channel != '1.61.0') && - !contains(matrix.host_os, 'windows') }} + - if: ${{ (matrix.target != 'aarch64-apple-ios' || matrix.rust_channel != '1.61.0') }} run: rustup toolchain install --component=llvm-tools-preview ${{ matrix.rust_channel }} - - if: ${{ (matrix.target != 'aarch64-apple-ios' || matrix.rust_channel != '1.61.0') && - !contains(matrix.host_os, 'windows') }} + - if: ${{ (matrix.target != 'aarch64-apple-ios' || matrix.rust_channel != '1.61.0') }} + shell: sh run: mk/check-symbol-prefixes.sh +${{ matrix.rust_channel }} --target=${{ matrix.target }} test-bench: @@ -412,14 +410,12 @@ jobs: mk/cargo.sh +${{ matrix.rust_channel }} test -vv --doc --target=${{ matrix.target }} ${{ matrix.cargo_options }} ${{ matrix.features }} ${{ matrix.mode }} # Check that all the needed symbol renaming was done. - # TODO: Do this check on Windows too. - - if: ${{ (matrix.target != 'aarch64-apple-ios' || matrix.rust_channel != '1.61.0') && - !contains(matrix.host_os, 'windows') }} + - if: ${{ (matrix.target != 'aarch64-apple-ios' || matrix.rust_channel != '1.61.0') }} run: rustup toolchain install --component=llvm-tools-preview ${{ matrix.rust_channel }} - - if: ${{ (matrix.target != 'aarch64-apple-ios' || matrix.rust_channel != '1.61.0') && - !contains(matrix.host_os, 'windows') }} + - if: ${{ (matrix.target != 'aarch64-apple-ios' || matrix.rust_channel != '1.61.0') }} + shell: sh run: mk/check-symbol-prefixes.sh +${{ matrix.rust_channel }} --target=${{ matrix.target }} # The wasm32-unknown-unknown targets have a different set of feature sets and @@ -473,7 +469,6 @@ jobs: ${{ matrix.webdriver }} mk/cargo.sh +${{ matrix.rust_channel }} test -vv --target=${{ matrix.target }} ${{ matrix.features }} ${{ matrix.mode }} # Check that all the needed symbol renaming was done. - # TODO: Do this check on Windows too. - run: rustup toolchain install --component=llvm-tools-preview ${{ matrix.rust_channel }} - run: mk/check-symbol-prefixes.sh +${{ matrix.rust_channel }} --target=${{ matrix.target }}