Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading while already in a tmux session #49

Closed
coreyja opened this issue Dec 24, 2019 · 3 comments · Fixed by #50
Closed

Support loading while already in a tmux session #49

coreyja opened this issue Dec 24, 2019 · 3 comments · Fixed by #50

Comments

@coreyja
Copy link
Contributor

coreyja commented Dec 24, 2019

System Info

OS: Mac OS 10.15.2
Muxed Version: v0.8.0

Description

When already inside a tmux session, muxed errors with a warning from tmux about nested sessions.
sessions should be nested with care, unset $TMUX to force

Steps to reproduce

  • tmux
  • muxed new test
  • muxed test

Expected

Muxed creates a detached session and switches tmux to that session

Actual

A tmux error message is printed to the terminal
sessions should be nested with care, unset $TMUX to force

Use Case

I have my terminal default to opening a tmux session, so I am almost never in a bare bash terminal. This reduces the usability to muxed since it can't be used to load a new project while in a tmux session.

@brianp
Copy link
Owner

brianp commented Dec 29, 2019

Hey @coreyja!

Thanks for giving Muxed a try. I too have seen this circumstance and generally thought "oh yeah I guess I should nest with care" and never really considered it more but I think your use case is entirely valid and also something I should consider doing myself.

I'm going to look to fix this. I'll ping back here once a PR is merged, and release produced.

Cheers, and thanks again!

@brianp
Copy link
Owner

brianp commented Jan 2, 2020

The 0.8.1 tag is up if you're building from source, or available on homebrew, and the releases page.

Let me know if it doesn't behave as expected. Right after the initial implementation I thought to myself "Oh yeah this is a quality of life improvement" haha. I hadn't realized how natural it had become for me to work around this before.

@coreyja
Copy link
Contributor Author

coreyja commented Jan 8, 2020

🎉 🎉 🎉

Oh this is great!! Thanks for getting this released! Just pulled the new release and it worked exactly as expected!

I'll let you know if I run into any issues or see anything weird!

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants