Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tabulation columns in diagnostic output #220

Closed
brendanzab opened this issue Mar 28, 2020 · 0 comments · Fixed by #252
Closed

Fix tabulation columns in diagnostic output #220

brendanzab opened this issue Mar 28, 2020 · 0 comments · Fixed by #252

Comments

@brendanzab
Copy link
Owner

Currently codespan-reporting treats tabs as being a constant width, but this is incorrect, as @legendiguess notes:

The other would be to only adjust the underline calculation to account for tabs in line, but I'm not sure if display of "\tt" is always 5 ascii characters.

\t move next characters to the next tabulation column. so basically it's adds from 1 to 4 ascii characters, dependent on caret position off last tabulation column

We'll need to change the source writer and the width calculuation to properly support tabulation columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant