Skip to content
This repository has been archived by the owner on Jan 4, 2019. It is now read-only.

Debug builds fail to link on Windows #67

Closed
Mossop opened this issue Sep 30, 2016 · 2 comments
Closed

Debug builds fail to link on Windows #67

Mossop opened this issue Sep 30, 2016 · 2 comments
Assignees

Comments

@Mossop
Copy link

Mossop commented Sep 30, 2016

  • Brave version: 1.4.8
  • Operating system: Windows 10

Debug builds fail at the linking stage with this error:

brave_lib.lib(brave_lib.profile_writer.obj) : error LNK2019: unresolved external symbol "public: __cdecl TemplateURL::~TemplateURL(void)" (??1TemplateURL@@QEAA@XZ) referenced in function "public: void * __cdecl TemplateURL::`scalar deleting destructor'(unsigned int)" (??_GTemplateURL@@QEAAPEAXI@Z)
brave.exe : fatal error LNK1120: 1 unresolved externals

Looks related to the importer code that was added in #57

@bridiver
Copy link
Collaborator

bridiver commented Sep 30, 2016

thanks! I had been testing on windows 7 and the debug builds didn't work at all so I didn't bother to fix the linking issues, but until recently I didn't realize they worked correctly on win10 so we'll get this fixed

@bridiver
Copy link
Collaborator

cc @darkdh

@darkdh darkdh self-assigned this Oct 1, 2016
@darkdh darkdh closed this as completed in 05c0198 Oct 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants