Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Brave version - Ubuntu Snap #9870

Closed
ghost opened this issue Jul 5, 2017 · 21 comments
Closed

Brave version - Ubuntu Snap #9870

ghost opened this issue Jul 5, 2017 · 21 comments

Comments

@ghost
Copy link

ghost commented Jul 5, 2017

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    Old Brave version on snap system

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    KDE Neon 5.10.3 (Ubuntu 16.04)

  • Brave Version (revision SHA):
    latest/beta: 0.15.1 (2) 149MB -
    latest/edge: 0.15.1 (2) 149MB -

  • Steps to reproduce:

    1. Open Terminal
    2. Send "Sudo snap install Brave"
    3. Check the version (Help - About Brave)
  • Actual result:
    0.15.1

  • Expected result:

= 0.17.13

@ghost ghost changed the title Brave version - Snap Ubuntu Brave version - Ubuntu Snap Jul 5, 2017
@cndouglas
Copy link

@bsclifton Is there some kind of script that needs to be run to fix this?

@bsclifton
Copy link
Member

@liunkae good question, I'm not sure... cc: @flexiondotorg

@posix4e
Copy link
Contributor

posix4e commented Aug 23, 2017

I have uploaded a snap preview package to my personal bucket (it will be done in 5 minutes or so)
http://storage.googleapis.com/posis-brave-mirror/

@posix4e posix4e self-assigned this Aug 23, 2017
@posix4e
Copy link
Contributor

posix4e commented Aug 23, 2017

On my preview i am getting

[29613:29613:0823/112423.250494:FATAL:zygote_host_impl_linux.cc(107)] No usable sandbox! Update your kernel or see https://chromium.googlesource.com/chromium/src/+/master/docs/linux_suid_sandbox_development.md for more information on developing with the SUID sandbox. If you want to live dangerously and need an immediate workaround, you can try using --no-sandbox.

Might be a snap dealbreaker

@posix4e
Copy link
Contributor

posix4e commented Aug 23, 2017

I was able to install in devmode and it worked though

@retrocausal
Copy link

retrocausal commented Aug 28, 2017

@posix4e or anybody who can bump up versions.. Hey! the snap for ubuntu like systems, needs a version bump.
current dev release is 0.18.x and the release on the snap is pointing to 0.17.x
I see that you are just using dump plugin on snpcraft. may be it is just the source you need to change and point it to 0.18.x tar.gz on this repo?

Or may be automate this via launchpad /travis/ anything really

@posix4e
Copy link
Contributor

posix4e commented Sep 5, 2017

@retrocausal you talking about the preview?

@retrocausal
Copy link

Nah. I meant, when we currently install brave as a snap, it installs v0.17.x
And if you have access to the snapcrafters file (yaml) ,

you could possibly bump the version up?

plugin: dump
    source: https://github.com/brave/browser-laptop/releases/download/v<current>dev/brave_<current>_amd64.deb
source-type: deb

should be just a change of a line if I am not wrong.

w.r.t automation,

I don't know who from brave is in touch with Martin/somebody from snapcraft,
but we could possibly attach the snapcraft.yaml file to the current release branch and mirror the build on launchpad every time a commit is made into the release branch

launchpad will build brave and release it to the desired channel on the snap store automatically then.

@Ads20000
Copy link

Ads20000 commented Sep 5, 2017

I noticed Evan linked this bug in the snapcrafters repo for the Brave snap which might be the blocker (using build.snapcraft.io would be easier than Launchpad for the Brave devs). Also @bbondy is cited as our Brave dev contact...

Sorry to bother you devs btw, just that we would love to see Brave released as a snap, up-to-date, and in the stable channel, but clearly there's stuff that needs to happen for that to happen! We should probably leave Martin and you guys to it :P

@posix4e
Copy link
Contributor

posix4e commented Sep 5, 2017

@Ads20000 no bother at all. I've got it.

@OpenSourceAnarchist
Copy link

@posix4e No hurry or anything, but is there an update on the status of this? I'm on Solus which has native Snap support and doing "refresh" on Brave hasn't updated the package. I see here that the version was bumped 8 days ago, but was this deployed?

I love Brave so much and would love to be running the latest versions!

@Ads20000
Copy link

Ads20000 commented Sep 13, 2017

@TheMarketAnarchist We can wait and I'm sure @posix4e will resolve it eventually but if you want to do something yourself I'm guessing taking the snapcraft.yaml from here and trying to work out a working one would be helpful. You'd need to learn some stuff about snapcraft and electron-builder though :)

@Ads20000
Copy link

Ads20000 commented Sep 13, 2017

Oh, as for the version bump, I've filed an issue and asked why Martin hasn't released it...I can see that's not autobuilding on the snapcraft build service...

Edit: as popey updates, yeah we're not building at the moment because we're handing over, so I guess we just need to wait! :)

@posix4e
Copy link
Contributor

posix4e commented Sep 13, 2017

If there's a patch in the meantime you'd like to see..

@OpenSourceAnarchist
Copy link

While an update was released 6 days ago, I was wondering if the Brave Snap Team is considering an auto-build and auto-update solution so that the Snap is kept up-to-date with the other versions. For instance, the Stable channel would be synced to the stable releases, edge to the master branch, etc.

If this is being discussed, could someone update me on the status? I'm just not sure what the plan is with the Snap version. Thanks!

@hugobuddel
Copy link
Contributor

hugobuddel commented Oct 10, 2017

The beta version should be 0.19 according to https://github.com/brave/browser-laptop/wiki/Release-channels, but installing Brave with snap install brave --beta gives 0.18.36.

@LaosPL
Copy link

LaosPL commented Dec 7, 2017

So it hasn't been fix yet ? Is there only beta channel for snap ?

@posix4e
Copy link
Contributor

posix4e commented Dec 7, 2017

@LaosPL Sorry I have been distracted on other things. If you wanna help we can push this forward quickly.

@LaosPL
Copy link

LaosPL commented Dec 8, 2017

@posix4e How can I help ?

@posix4e
Copy link
Contributor

posix4e commented Dec 8, 2017

@LaosPL for now email me at posix4e at gmail .com and we can discuss snap.

@bsclifton
Copy link
Member

Closing as this has been fixed. Our snaps should be up to date

@bsclifton bsclifton removed this from the Triage Backlog milestone Jul 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants