Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Polish groupedItem button #9252

Closed
luixxiul opened this issue Jun 4, 2017 · 0 comments
Closed

Polish groupedItem button #9252

luixxiul opened this issue Jun 4, 2017 · 0 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jun 4, 2017

Test plan

#9357 (comment)


Describe the issue you encountered: Polish groupedItem button.

Remove margin from browserButton and add it to groupedItem. A button as such does not require margin. Since the button requires the margin when it is grouped with another button in the same wrapper, adding margin to BrowserButton with groupedItem is a better solution than adding it to all buttons, some of whose margin would be canceled with margin: 0.

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues:

@luixxiul luixxiul added misc/button polish Nice to have — usually related to front-end/visual tasks. labels Jun 4, 2017
@luixxiul luixxiul added this to the 0.18.x milestone Jun 4, 2017
@luixxiul luixxiul self-assigned this Jun 4, 2017
@alexwykoff alexwykoff modified the milestones: 0.19.x, 0.18.x (Frozen, only critical adds from here) Jun 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants