Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Change breakpoint for close tab icon visibility #8130

Closed
cezaraugusto opened this issue Apr 8, 2017 · 1 comment · Fixed by #8411
Closed

Change breakpoint for close tab icon visibility #8130

cezaraugusto opened this issue Apr 8, 2017 · 1 comment · Fixed by #8411
Assignees
@cezaraugusto
Labels
feature/tabsbar QA/test-plan-specified release-notes/include

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Apr 8, 2017 •
edited by luixxiul
Loading

Test plan

#8411 (comment)

Per @bradleyrichter request, we want it changed from small (46px) to largeMedium (83px).

UI change be like: close icon will be visible only when tab is active, starting from 83px.
@cezaraugusto cezaraugusto added this to the 0.14.2 milestone Apr 8, 2017
@cezaraugusto cezaraugusto self-assigned this Apr 8, 2017
@cezaraugusto cezaraugusto mentioned this issue Apr 10, 2017
Closed
@cezaraugusto
Copy link
Contributor Author

moving to 0.14.3

@cezaraugusto cezaraugusto modified the milestones: 0.14.3, 0.14.2 Apr 11, 2017
@cezaraugusto cezaraugusto mentioned this issue Apr 25, 2017
Merged
4 tasks
This was referenced May 2, 2017
Closed
Closed
Closed
Closed
@cezaraugusto cezaraugusto reopened this Jun 15, 2017
@cezaraugusto cezaraugusto modified the milestones: 0.17.x (Beta Channel), 0.15.300 (Frozen, only critical adds from here) Jun 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
feature/tabsbar QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update min-threshold for closing a tab brave/browser-laptop
4 participants
@alexwykoff @luixxiul @cezaraugusto @srirambv