Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Last contribution date shows Your first contribution will be {{reconcileDate}} #7735

Closed
srirambv opened this issue Mar 15, 2017 · 3 comments
Closed

Comments

@srirambv
Copy link
Collaborator

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Last contribution date shows Your first contribution will be {{reconcileDate}}

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    0.14.0 Preview 1

  • Steps to reproduce:

    1. Change Language to Russian, restart the browser
    2. Enable Payments
    3. Last contribution read Your first contribution will be {{reconcileDate}}
  • Actual result:
    Last contribution read Your first contribution will be {{reconcileDate}}

  • Expected result:
    Should show translated version of No previous contributions

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Not checked

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    Russian
    image
    English
    image

  • Any related issues:
    Missing l10n strings - Simplified Chinese #6309

@srirambv srirambv added the l10n label Mar 15, 2017
@srirambv srirambv added this to the 1.0.0 milestone Mar 15, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Jun 4, 2017

This is thought to have been fixed.

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Jun 4, 2017
@bsclifton
Copy link
Member

@luixxiul @srirambv can we retest this with our most recent build? I also believe it's fixed (although, I can't find the related PRs)

@srirambv
Copy link
Collaborator Author

srirambv commented Jun 5, 2017

Tested this on 0.16.100 and text is properly translated. Can't test it on 0.16.2 as its blocked on #9269 . Will give it a test once 0.16.2 build is fixed.

Closing the issue for now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.