Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Use <SettingTextbox> for the textbox on the dialog of enabling Sync #7360

Closed
ayumi opened this issue Feb 23, 2017 · 1 comment
Closed

Use <SettingTextbox> for the textbox on the dialog of enabling Sync #7360

ayumi opened this issue Feb 23, 2017 · 1 comment

Comments

@ayumi
Copy link
Contributor

ayumi commented Feb 23, 2017

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    The Sync enable dialogs prompt for device nickname using <input /> elements. We would prefer they used SettingText because it's cleaner. We tried to do this in Use <SettingTextbox> for the textbox on the dialog of enabling Sync #7164 however it regressed nicknaming of devices

Previously I tried to use a Textbox however I couldn't get the prop ref={} to work so the input didn't work[0]. I gave up and used a standard input.
This branch doesn't seem to set the device name either.
[0] Maybe this: https://facebook.github.io/react/docs/refs-and-the-dom.html

Test Plan:

  1. Clear profile
  2. Enable sync and name the device
  3. Observe terminal for the device name– should not be "browser-laptop"

Also tested by: yarn test -- --grep='"^Sync Panel"'

cc @luixxiul @bsclifton

@luixxiul
Copy link
Contributor

luixxiul commented Apr 5, 2017

Closing in favor of PR #8044

@luixxiul luixxiul closed this as completed Apr 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants