You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
The Sync enable dialogs prompt for device nickname using <input /> elements. We would prefer they used SettingText because it's cleaner. We tried to do this in Use <SettingTextbox> for the textbox on the dialog of enabling Sync #7164 however it regressed nicknaming of devices
Previously I tried to use a Textbox however I couldn't get the prop ref={} to work so the input didn't work[0]. I gave up and used a standard input.
This branch doesn't seem to set the device name either.
[0] Maybe this: https://facebook.github.io/react/docs/refs-and-the-dom.html
Test Plan:
Clear profile
Enable sync and name the device
Observe terminal for the device name– should not be "browser-laptop"
Also tested by: yarn test -- --grep='"^Sync Panel"'
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
The Sync enable dialogs prompt for device nickname using
<input />
elements. We would prefer they used SettingText because it's cleaner. We tried to do this in Use <SettingTextbox> for the textbox on the dialog of enabling Sync #7164 however it regressed nicknaming of devicesPreviously I tried to use a Textbox however I couldn't get the prop ref={} to work so the input didn't work[0]. I gave up and used a standard input.
This branch doesn't seem to set the device name either.
[0] Maybe this: https://facebook.github.io/react/docs/refs-and-the-dom.html
Test Plan:
Also tested by: yarn test -- --grep='"^Sync Panel"'
cc @luixxiul @bsclifton
The text was updated successfully, but these errors were encountered: