Stop page load button doesn't stop loading the page, Esc does

[srirambv]

Test Plan

1. Visit http://www.espnfc.com/
2. Let the page load
3. Press reload
4. Quickly (as fast as you can) click stop
5. Page should stop loading and a partially loaded page will be rendered

Original issue description

• Did you search for similar issues before submitting this one?
  Yes

• Describe the issue you encountered:
  Reported by user in community https://community.brave.com/t/brave-loading-error/1341
  Stop page load button doesn't stop loading the page, Esc does

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 10 x64

• Brave Version (revision SHA):
  Brave 0.13.5
  rev 59a41eb

• Steps to reproduce:

  1. Open any page which has lot of content in it
  2. Click on the stop loading button in URL bar, doesn't stop loading the page
  3. Reload the same page and press Esc immediately, page load stops

• Actual result:
  Clicking on stop loading button doesn't stop the page load

• Expected result:
  Should stop the page load when stop loading button is clicked, functinality should be same as pressing Esc button

• Will the steps above reproduce in a fresh profile? If not what other info can be added?
  Yes

• Is this an issue in the currently released version?
  Yes same on 0.13.4

• Can this issue be consistently reproduced?
  Yes

• Extra QA steps:
  1.
  2.
  3.

• Screenshot if needed:
  

• Any related issues:
  cc: @bsclifton

[bsclifton]

@bbondy do you remember why the IPC calls were removed with this commit?
4507f5e

edit:
nevermind- I totally see why. The stop button is just triggering the handler in urlbar. There are no other listeners 😛

[bsclifton]

Hitting escape works great- the inputHandler script will send the renderer a stop-load event. When the stop button is pushed, nothing is sent... in fact, it causes the frame to load again. I'm curious if this ever worked properly?