Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor about:styles with Aphrodite #7201

Closed
luixxiul opened this issue Feb 11, 2017 · 4 comments
Closed

Refactor about:styles with Aphrodite #7201

luixxiul opened this issue Feb 11, 2017 · 4 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Feb 11, 2017

Test Plan

make sure about:styles is as it should be

Original issue description

Refactor about:styles with Aphrodite. It will let us remove less/about/styles.less, which is used only on that page.

@luixxiul
Copy link
Contributor Author

luixxiul commented Feb 25, 2017

<div className='container'>
<h2>Plain textarea</h2>
<TextArea placeholder='TextArea' />
<pre><code>
const { '{TextArea}' } = require('../../app/renderer/components/textbox'){'\n'}
&lt;TextArea />
</code></pre>
</div>
<div className='container'>
<h2>Default textarea; font size is specified</h2>
<DefaultTextArea placeholder='DefaultTextArea' />
<pre><code>
const { '{DefaultTextArea}' } = require('../../app/renderer/components/textbox'){'\n'}
&lt;DefaultTextArea />
</code></pre>
</div>
is broken because of this commit: 269d37b for #7163. I will push a fix.

@srirambv
Copy link
Collaborator

image
Small button definitely doesn't look small 😄

@luixxiul
Copy link
Contributor Author

That's another issue which I have shared with @bradleyrichter and @bsclifton in a commit some times ago and I'm going to fix it by refactoring findBar with Aphrodite.

@bradleyrichter
Copy link
Contributor

big is the new small. 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.