This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 974
Translate Bookmarks Manager #7130
Milestone
Comments
Good place to start looking https://github.com/brave/browser-laptop/blob/master/js/about/bookmarks.js#L337 |
4 tasks
PR: #7139 |
@luixxiul This is a very minor change. I don't think we need QA for this (we can't even realistically verify until the texts are translated and imported), and I don't think it needs to be included in the release notes. |
I could verify change by myself by doing l10n on Transifex so no worry |
Also the issue can be named "more l10n done" etc on release notes if it is worth mentioning. At least this does not have to be excluded from the release note so Iabelled to include it |
Fair enough. If/when we import the translations from Transifex, we can use Spanish to test (I just translated it there). |
This was referenced Feb 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
If translations come in soon:
otherwise, no testing needed
original issue text
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
Title and Last visited in Bookmarks Manager are not translated.
Platform (Win7, 8, 10? macOS? Linux distro?):
All
Brave Version (revision SHA):
f7a5e17
Steps to reproduce:
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Yes
Is this an issue in the currently released version?
Yes
Can this issue be consistently reproduced?
Yes
The text was updated successfully, but these errors were encountered: