Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

No-script notification buttons need margins #6783

Closed
srirambv opened this issue Jan 20, 2017 · 3 comments
Closed

No-script notification buttons need margins #6783

srirambv opened this issue Jan 20, 2017 · 3 comments
Assignees
@luixxiul
Labels
regression

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jan 20, 2017 •
edited by luixxiul
Loading

  • Did you search for similar issues before submitting this one?

  • Describe the issue you encountered:
    No-script notification buttons needs padding

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    Brave 0.13.0
    rev fefd17c

  • Steps to reproduce:

    1. Visit https://twitter.com
    2. Enable block script from preferences
    3. Click on the no-script button in URL bar
    4. Buttons in no-script notification is all stuck to each other, needs spacing

  • Screenshot if needed:
    image

  • Any related issues: Buttons alignment on about:certerror and NoScript dialog #6317

Test plan

  1. Open about:preferences#shields
  2. Enable "Block Scripts"
  3. Open https://brianbondy.com/
  4. Click noScript button on the navigation bar
  5. Make sure there are margins among the buttons

screenshot 2017-01-21 3 01 12
@srirambv srirambv added misc/button polish Nice to have — usually related to front-end/visual tasks. labels Jan 20, 2017
@srirambv srirambv added this to the 0.13.1 milestone Jan 20, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Jan 20, 2017 •
edited
Loading

The fix which is similar to #6317 for #5916 should work here too

@luixxiul luixxiul self-assigned this Jan 20, 2017
@luixxiul luixxiul mentioned this issue Jan 20, 2017
Closed
4 tasks
@luixxiul luixxiul changed the title No-script notification buttons needs padding No-script notification buttons need margins Jan 21, 2017
@bsclifton bsclifton modified the milestones: 0.13.2, 0.13.1 Jan 26, 2017
@luixxiul luixxiul mentioned this issue Feb 10, 2017
Closed
@luixxiul luixxiul removed this from the 0.13.4 milestone Feb 10, 2017
@diracdeltas
Copy link
Member

This was incidentally fixed by #7272

@alexwykoff
Copy link
Contributor

Agreed. No longer a bug.

@luixxiul luixxiul removed misc/button polish Nice to have — usually related to front-end/visual tasks. QA/test-plan-specified labels Mar 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@diracdeltas @alexwykoff @luixxiul @bsclifton @srirambv